fix: add memberId filter to identity verification activity query (CM-1011)#4007
Merged
fix: add memberId filter to identity verification activity query (CM-1011)#4007
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the verifyMemberIdentity endpoint by ensuring the activityRelations lookup is filtered by memberId, allowing Postgres to use the existing ix_activityRelations_memberId index and avoid expensive scans on a very large table.
Changes:
- Add
memberIdto thequeryActivityRelationsfilter used when un-verifying a member identity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyMemberIdentityendpoint queriesactivityRelations(840M rows) byusernameandplatformonly — neither column is indexed, causing a full sequential scan and read timeoutsmemberIdto the filter uses the existingix_activityRelations_memberIdindex, reducing query cost from ~34.8M to ~53K (660x improvement)Note
Low Risk
Low risk, narrowly scoped filter change to an internal count query; main impact is improved performance and reduced timeout risk when unverifying identities.
Overview
When
verifyMemberIdentityis called withverified=false, theactivityRelationsexistence check is now additionally filtered bymemberId(alongsideusernameandplatform). This scopes the count query to the current member, allowing index usage and preventing slow full-table scans/timeouts before deciding to delete the identity vs. unmerge.Reviewed by Cursor Bugbot for commit ee9943d. Bugbot is set up for automated code reviews on this repo. Configure here.